Skip to content

Debug: rework conditional erasure, fix stepping over literals#19897

Merged
T-Gro merged 7 commits into
dotnet:mainfrom
auduchinok:debug-sequencePoint-erased
Jun 12, 2026
Merged

Debug: rework conditional erasure, fix stepping over literals#19897
T-Gro merged 7 commits into
dotnet:mainfrom
auduchinok:debug-sequencePoint-erased

Conversation

@auduchinok

@auduchinok auduchinok commented Jun 5, 2026

Copy link
Copy Markdown
Member

Continues #19894.

Removes an old workaround for conditional call erasure that could prevent generating sequence points for unit expressions. Adds a new helper for marking hidden sequence points. Restores stepping over simple literal bindings that got broken with realsig+.

@auduchinok auduchinok requested a review from a team as a code owner June 5, 2026 10:26
@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@auduchinok

auduchinok commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@T-Gro The release notes comment is now missing the link to open the online editor. Could we have it back, please? 🙂

@T-Gro T-Gro mentioned this pull request Jun 5, 2026
Merged
@auduchinok auduchinok force-pushed the debug-sequencePoint-erased branch from 5214f29 to e1a3f86 Compare June 5, 2026 11:05
@github-actions github-actions Bot added ⚠️ Affects-Compiler-Output Tooling check: PR touches IL emission or codegen ⚠️ Affects-Bootstrap Tooling check: PR touches compiler bootstrap chain labels Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Bootstrap, Affects-Compiler-Output
Affects-Bootstrap: modifies pars.fsy (parser generator input)
Affects-Compiler-Output: modifies IlxGen.fs (IL emission)

Generated by PR Tooling Safety Check · opus46 4.3M · ◷

@auduchinok auduchinok changed the title Sequence points: rework conditional erasure, fix stepping over literals Debug: rework conditional erasure, fix stepping over literals Jun 5, 2026
@auduchinok

auduchinok commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@T-Gro The release notes comment is now missing the link to open the online editor. Could we have it back, please? 🙂

Ah, my bad. The branch already had the release notes from the other PR, that's why there was no link.

@auduchinok

auduchinok commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

Please merge #19894 first.

@auduchinok auduchinok mentioned this pull request Jun 7, 2026
Open
auduchinok and others added 5 commits June 8, 2026 13:15
@auduchinok @claude
Sequence points: rework conditional erasure, fix stepping over literals
01af60f 
Add `isHidden` to `DebugPointAtLeafExpr.Yes` to express it explicitly in the typed tree

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@auduchinok
Print source in sequence point dump
61d9319
@auduchinok
Fantomas
c52d97b
@auduchinok @claude
Fix hasVisibleDebugPoint, update baselines
82f2523 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@auduchinok @claude
Update baselines
773d15c 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@auduchinok auduchinok force-pushed the debug-sequencePoint-erased branch from aa147a5 to 773d15c Compare June 8, 2026 11:15
@auduchinok auduchinok mentioned this pull request Jun 10, 2026
Open
@auduchinok

auduchinok commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

This is ready.

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Jun 12, 2026
@T-Gro T-Gro enabled auto-merge (squash) June 12, 2026 18:56
@T-Gro

T-Gro commented Jun 12, 2026

Copy link
Copy Markdown
Member

This is very nice. I also like getting rid of range0 for logical flow inside IlxGen, this is certainly a move in the right direction 👍

@T-Gro T-Gro merged commit 9bc13b3 into dotnet:main Jun 12, 2026
50 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Jun 12, 2026
This was referenced Jun 13, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

⚠️ Affects-Bootstrap Tooling check: PR touches compiler bootstrap chain ⚠️ Affects-Compiler-Output Tooling check: PR touches IL emission or codegen

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@auduchinok @T-Gro